Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unsafe signatures for Java 8, review Java 7 #19

Closed
GoogleCodeExporter opened this issue Mar 14, 2015 · 5 comments
Closed

Add unsafe signatures for Java 8, review Java 7 #19

GoogleCodeExporter opened this issue Mar 14, 2015 · 5 comments

Comments

@GoogleCodeExporter
Copy link

Currently Java 7 and Java 8 unsafe signatures are just copies of Java 6.

We should check especially Java 8 for new method signatures that use default 
charset, default locale, and default timezone. Java 7 is unlikely that new ones 
are introduced, but Java 8 has many new ones (because of introduction of 
closures).

Original issue reported on code.google.com by uwe.h.schindler on 9 Nov 2013 at 11:29

@GoogleCodeExporter
Copy link
Author

This is a followup of issue #16.

Original comment by uwe.h.schindler on 9 Nov 2013 at 11:30

@GoogleCodeExporter
Copy link
Author

We also need a way to validate those signatures in test cases. This is not easy 
to do, because you need the correct JDK at test runtime. We compile 
forbidden-apis with Java 5 only.

The idea is to have a special test, that loads the signatures matching the 
current JVM. Just to validate that they are correct.

jdk-deprecated does not need any test, because the signatures are autogenerated.

Original comment by uwe.h.schindler on 14 Sep 2014 at 5:22

@GoogleCodeExporter
Copy link
Author

For now I committed a new offender in Java 7: Scanner#<init>(java.nio.file.Path)

Original comment by uwe.h.schindler on 14 Sep 2014 at 6:49

@GoogleCodeExporter
Copy link
Author

I committed an Ant target to check the signatures for the current JVM: "ant 
check-bundled-signatures" (revision 312 and revision 313)

Original comment by uwe.h.schindler on 14 Sep 2014 at 10:01

uschindler added a commit that referenced this issue Mar 14, 2015
@uschindler uschindler changed the title Add new unsafe signatures in Java 8, review Java 7 Add new unsafe signatures for Java 8 and Java 9, review Java 7 Mar 29, 2015
@uschindler uschindler changed the title Add new unsafe signatures for Java 8 and Java 9, review Java 7 Add new unsafe signatures for Java 8, review Java 7 Mar 29, 2015
@uschindler uschindler changed the title Add new unsafe signatures for Java 8, review Java 7 Add unsafe signatures for Java 8, review Java 7 Mar 29, 2015
@uschindler uschindler self-assigned this Apr 26, 2015
uschindler added a commit that referenced this issue Jun 20, 2015
Issue #19: Add java.time APIs using default timezone and default locale
@uschindler uschindler added this to the 1.9 milestone Jun 20, 2015
@uschindler
Copy link
Member

I close this issue because it looks like done. I opened another issue separately to review Java 7 and Java 8 again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants