Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message per line #128

Closed
leventov opened this issue Sep 25, 2017 · 2 comments
Closed

Error message per line #128

leventov opened this issue Sep 25, 2017 · 2 comments
Assignees
Milestone

Comments

@leventov
Copy link

Is there a way to configure error message per line, except prepending each line with another @defaultMessage line?

@uschindler
Copy link
Member

Yes, just do (example from Lucene having both variants (https://github.com/apache/lucene-solr/blob/master/lucene/tools/forbiddenApis/tests.txt):

junit.framework.TestCase @ All classes should derive from LuceneTestCase

java.util.Random#<init>() @ Use RandomizedRunner's random() instead
java.lang.Math#random() @ Use RandomizedRunner's random().nextDouble() instead

# TODO: fix tests that do this!
#java.lang.System#currentTimeMillis() @ Don't depend on wall clock times
#java.lang.System#nanoTime() @ Don't depend on wall clock times

com.carrotsearch.randomizedtesting.annotations.Seed @ Don't commit hardcoded seeds

@defaultMessage Use LuceneTestCase.collate instead, which can avoid JDK-8071862
java.text.Collator#compare(java.lang.Object,java.lang.Object)
java.text.Collator#compare(java.lang.String,java.lang.String)

@uschindler uschindler self-assigned this Sep 26, 2017
@uschindler
Copy link
Member

It would just be good to add some documentation about the signature files. So I keep this issue open. That's really needed - sorry for not yet adding this.

@uschindler uschindler added this to the 2.4 milestone Oct 2, 2017
centic9 pushed a commit to centic9/forbidden-apis that referenced this issue Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants