Crash in BleDisClient.readDisInfoWithKeysAsStrings

[korzonkiee]

Platform on which you observed the bug:

• Android
• iOS
• Other
• Platform is not relevant for this bug

Device on which you observed the bug:

• Polar OH1
• Polar Verity Sense
• Polar H10
• Polar H9
• Other
• Device is not relevant for this bug

Describe the bug
App randomly crashes for some of our users. Looking at the crash report, it seems that it is a null-reference exception, where self is null. Most likely can be fixed by using weak self and doing a null-check before accessing self.

How to Reproduce
No clear reproduction steps, it happens randomly.

Expected behavior
App should not crash.

Screenshots and logs

[pth-pe-gh]

FLOW-60720

[korzonkiee]

We fixed it in our internal fork.

korzonkiee@771c622

[pth-pe-gh]

Looking at the screen shot in the report, this may have been caused by non-thread safe access to dictionary; as the problem seems to happen on getting dictionary key values count. The proposed fix may not be enough to prevent such crash; if it is, it may cause some other functionality to fail.

Need to check how the dictionary is accessed to see if/when access to dictionary happens from multiple threads (e.g. from different queues)

[pth-pe-gh]

Will make update to SDK to fix related multithreading issue with dictionary.

[pth-pe-gh]

Change to synchronise dictionary access will be in next SDK release.