Add batch clean instances maintian interface #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #784 +/- ##
==========================================
- Coverage 57.11% 57.04% -0.07%
==========================================
Files 159 161 +2
Lines 28805 28850 +45
==========================================
+ Hits 16451 16458 +7
- Misses 10155 10185 +30
- Partials 2199 2207 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chuntaojun
reviewed
Nov 7, 2022
chuntaojun
reviewed
Nov 7, 2022
|
单元测试没有过，看看问题修复下 |
chuntaojun
reviewed
Nov 10, 2022
store/boltdb/maintain.go
Outdated
| @@ -23,5 +23,5 @@ type maintainStore struct { | |||
|
|
|||
| // BatchCleanDeletedInstances | |||
| func (m *maintainStore) BatchCleanDeletedInstances(batchSize uint32) (uint32, error) { | |||
| return 0, nil | |||
| return m.handler.BatchDeleteInvalidValues(tblNameInstance, batchSize) | |||
There was a problem hiding this comment.
更合理的方式是不是应该用 m.handler 先 loadByilter 一把，然后在删除？不应该吧逻辑写在BoltDB的封装里面，不然太强要求Valid属性
chuntaojun
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide issue(s) of this PR:
Fixes https://github.com/polarismesh/polaris-cleanup/issues/2
为了移除 cleanup 项目对 store 的直接依赖，在 polaris-server 中新增一个批量清除软删除实例的运维接口
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.
Please check any characteristics that apply to this pull request.