Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve code golangci config #765

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Conversation

houseme
Copy link
Member

@houseme houseme commented Oct 21, 2022

Please provide issue(s) of this PR:
Fixes #

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Configuration
  • Docs
  • Installation
  • Performance and Scalability
  • Naming
  • HealthCheck
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #765 (0a654b0) into main (a0d0862) will increase coverage by 0.00%.
The diff coverage is 42.10%.

@@           Coverage Diff           @@
##             main     #765   +/-   ##
=======================================
  Coverage   56.61%   56.61%           
=======================================
  Files         159      159           
  Lines       28978    28978           
=======================================
+ Hits        16405    16406    +1     
- Misses      10395    10397    +2     
+ Partials     2178     2175    -3     
Impacted Files Coverage Δ
cache/instance.go 74.55% <ø> (ø)
config/config_file.go 45.79% <ø> (-0.12%) ⬇️
store/boltdb/user.go 58.56% <ø> (ø)
store/sqldb/default.go 72.12% <ø> (ø)
store/sqldb/instance.go 51.38% <0.00%> (ø)
service/routing_config_v1tov2.go 33.80% <25.00%> (ø)
service/routing_config_v2.go 50.71% <30.00%> (ø)
store/boltdb/service.go 55.94% <58.33%> (+0.31%) ⬆️
cache/namespace.go 76.92% <100.00%> (ø)
config/resource_listener.go 87.87% <100.00%> (-0.36%) ⬇️
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

funlen:
# Checks the number of lines in a function.
# If lower than 0, disable the check.
# Default: 60
lines: 120
lines: 210
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里保留为120吧

@chuntaojun chuntaojun merged commit f15f6a2 into polarismesh:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants