Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修改CHARSET = utf8mb4 COLLATE = utf8mb4_bin; #442

Merged
merged 5 commits into from
Jun 16, 2022

Conversation

HIPIAOYI
Copy link

@HIPIAOYI HIPIAOYI commented Jun 16, 2022

Please provide issue(s) of this PR:
Fixes #430

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Configuration
  • Docs
  • Installation
  • Performance and Scalability
  • Naming
  • HealthCheck
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #442 (c75df14) into main (4632805) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #442   +/-   ##
=======================================
  Coverage   22.17%   22.17%           
=======================================
  Files         185      185           
  Lines       25159    25159           
=======================================
+ Hits         5578     5580    +2     
+ Misses      18738    18736    -2     
  Partials      843      843           
Impacted Files Coverage Δ
store/boltdb/instance.go 53.80% <0.00%> (+0.47%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@chuntaojun
Copy link
Member

数据库字段的字符集其实可以不用设置了,集成的是表的字符比较级,理论上只需要设置好库的就可以,表默认继承所在库的字符集 & 比较集,字段集成表的

如果表级别没有设置CHARSET和COLLATE,则表级别会继承库级别的CHARSET与COLLATE
如果列级别没有设置CHARSET和COLATE,则列级别会继承表级别的CHARSET与COLLATE。

因此我觉得,表、列级别不需要在进行设置 CHARSET和COLLATE了,只需要保证库本身指定了 CHARSET和COLLATE 即可

@HIPIAOYI
Copy link
Author

数据库字段的字符集其实可以不用设置了,集成的是表的字符比较级,理论上只需要设置好库的就可以,表默认继承所在库的字符集 & 比较集,字段集成表的

如果表级别没有设置CHARSET和COLLATE,则表级别会继承库级别的CHARSET与COLLATE 如果列级别没有设置CHARSET和COLATE,则列级别会继承表级别的CHARSET与COLLATE。

因此我觉得,表、列级别不需要在进行设置 CHARSET和COLLATE了,只需要保证库本身指定了 CHARSET和COLLATE 即可

get,更加优雅,马上修改

@chuntaojun chuntaojun added store issue-shoot issue-shoot activity labels Jun 16, 2022
@chuntaojun
Copy link
Member

1、SQL文本建议格式化一下
2、scripts/delta 里面的SQL看看也处理下?

@HIPIAOYI
Copy link
Author

HIPIAOYI commented Jun 16, 2022

1、SQL文本建议格式化一下 2、scripts/delta 里面的SQL看看也处理下?

1、格式化是不是应该用插件工具(VSCode SQL Beautify插件),我找个插件来处理下
2、好的

@chuntaojun
Copy link
Member

1、SQL文本建议格式化一下 2、scripts/delta 里面的SQL看看也处理下?

1、格式化是不是应该用插件工具(VSCode SQL Beautify插件),我找个插件来处理下 2、好的

都可以,只要SQL文本格式化下,好审查就行

@andrewshan
Copy link
Member

1、SQL文本建议格式化一下 2、scripts/delta 里面的SQL看看也处理下?

1、格式化是不是应该用插件工具(VSCode SQL Beautify插件),我找个插件来处理下 2、好的

可以用插件格式化一下

@houseme
Copy link
Member

houseme commented Jun 16, 2022

1、SQL文本建议格式化一下 2、scripts/delta 里面的SQL看看也处理下?

1、格式化是不是应该用插件工具(VSCode SQL Beautify插件),我找个插件来处理下 2、好的

可以用插件格式化一下

goland以及这个家族的IDE都可以可以格式化

@chuntaojun
Copy link
Member

建议使用jetbrain中的DataGrip这个ide来进行sql的格式化

@chuntaojun
Copy link
Member

企业微信截图_f9af43a1-014f-487d-ad43-d739a58473fd

Copy link
Member

@andrewshan andrewshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewshan andrewshan merged commit 4d7c5ee into polarismesh:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue-shoot issue-shoot activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

polaris建库sql支持utf8bm4
4 participants