Skip to content
revive

fix:修复监控数据上报无法清理数据问题 #278

Sign in to view logs

fix:修复监控数据上报无法清理数据问题

fix:修复监控数据上报无法清理数据问题 #278

Triggered via pull request July 15, 2024 14:04
@chuntaojunchuntaojun
opened #209
chuntaojun:feat/config_api
Status Success
Total duration 53s
Artifacts –

revive.yml

on: pull_request
Matrix: Run Revive Action
Fit to window
Zoom out
Zoom in

Annotations

66 warnings
Run Revive Action (1.17.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.17.x): examples/configuration/crud/main.go#L18
should have a package comment
Run Revive Action (1.17.x): pkg/stat/loadbalance/lb.go#L27
type name will be used as loadbalance.LoadBalanceGauge by other packages, and that stutters; consider calling this Gauge
Run Revive Action (1.17.x): pkg/plugin/weightadjuster/proxy.go#L18
should have a package comment
Run Revive Action (1.17.x): examples/configuration/encrypt/main.go#L18
should have a package comment
Run Revive Action (1.17.x): pkg/plugin/servicerouter/servicerouter.go#L30
exported type FailOverType should have comment or be unexported
Run Revive Action (1.17.x): examples/mock/main.go#L69
invalid file examples/mock/main.go: examples/mock/main.go:69:13: expected ';', found 0 (and 1 more errors)
Run Revive Action (1.17.x): examples/configuration/group/main.go#L18
should have a package comment
Run Revive Action (1.17.x): pkg/clock/clock.go#L77
exported function CurrentMillis should have comment or be unexported
Run Revive Action (1.17.x): pkg/stat/loadbalance/lb.go#L18
should have a package comment
Run Revive Action (1.17.x): pkg/plugin/servicerouter/servicerouter.go#L34
exported const FailOverAll should have comment (or a comment on this block) or be unexported
Run Revive Action (1.19.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.19.x): examples/circuitbreaker/instance/provider/main.go#L17
should have a package comment
Run Revive Action (1.19.x): pkg/model/pb/metric/code.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/configuration/crud/main.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/configuration/fallback/main.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/configuration/encrypt/main.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/configuration/group/main.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/configuration/normal/main.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/quickstart/provider/main.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/mock/main.go#L69
invalid file examples/mock/main.go: examples/mock/main.go:69:13: expected ';', found 0 (and 1 more errors)
Run Revive Action (1.19.x): examples/ratelimit/consumer/main.go#L18
should have a package comment
Run Revive Action (1.18.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.18.x): examples/circuitbreaker/interface/consumer/main.go#L95
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.18.x): examples/circuitbreaker/interface/consumer/main.go#L75
parameter 'ctx' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.18.x): pkg/model/pb/metric/v2/code.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/circuitbreaker/instance/provider/main.go#L72
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.18.x): examples/circuitbreaker/instance/consumer/main.go#L99
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.18.x): benchmark/benchmain/main.go#L325
parameter 'pos' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.18.x): examples/quickstart/consumer/main.go#L58
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.18.x): examples/mock/main.go#L69
invalid file examples/mock/main.go: examples/mock/main.go:69:13: expected ';', found 0 (and 1 more errors)
Run Revive Action (1.18.x): examples/configuration/group/main.go#L18
should have a package comment
Run Revive Action (1.18.x): pkg/plugin/circuitbreaker/proxy.go#L32
comment on exported method Proxy.CheckResource should be of the form "CheckResource ..."
Run Revive Action (1.15.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.15.x): examples/watch/service/longpull/main.go#L18
should have a package comment
Run Revive Action (1.15.x): examples/mock/main.go#L69
invalid file examples/mock/main.go: examples/mock/main.go:69:13: expected ';', found 0 (and 1 more errors)
Run Revive Action (1.15.x): examples/watch/service/longpull/main.go#L77
should omit type uint64 from declaration of var index; it will be inferred from the right-hand side
Run Revive Action (1.15.x): examples/watch/service/longpull/main.go#L52
should omit type uint64 from declaration of var index; it will be inferred from the right-hand side
Run Revive Action (1.15.x): examples/circuitbreaker/instance/consumer/main.go#L18
should have a package comment
Run Revive Action (1.15.x): examples/configuration/group/main.go#L18
should have a package comment
Run Revive Action (1.15.x): pkg/plugin/healthcheck/healthcheck.go#L18
should have a package comment
Run Revive Action (1.15.x): pkg/model/pb/metric/code.go#L28
exported const ExecuteSuccess should have comment (or a comment on this block) or be unexported
Run Revive Action (1.15.x): examples/watch/instance/longpull/main.go#L18
should have a package comment
Run Revive Action (1.15.x): examples/ratelimit/consumer/main.go#L18
should have a package comment
Run Revive Action (1.16.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.16.x): benchmark/benchmain/main.go#L47
const operationRpcNaming should be operationRPCNaming
Run Revive Action (1.16.x): benchmark/benchmain/main.go#L46
const operationRpcDirect should be operationRPCDirect
Run Revive Action (1.16.x): examples/circuitbreaker/instance/consumer/main.go#L18
should have a package comment
Run Revive Action (1.16.x): benchmark/benchsimple/main.go#L71
var maxQps should be maxQPS
Run Revive Action (1.16.x): examples/circuitbreaker/instance/consumer/main.go#L99
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.16.x): examples/configuration/crud/main.go#L18
should have a package comment
Run Revive Action (1.16.x): benchmark/benchsimple/main.go#L239
func runQpsLimitFeature should be runQPSLimitFeature
Run Revive Action (1.16.x): benchmark/benchsimple/main.go#L181
struct field maxQps should be maxQPS
Run Revive Action (1.16.x): benchmark/benchsimple/main.go#L414
var useQpsLimit should be useQPSLimit
Run Revive Action (1.16.x): examples/activehealthcheck/main.go#L18
should have a package comment
Run Revive Action (1.20.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.20.x): examples/configuration/fallback/main.go#L18
should have a package comment
Run Revive Action (1.20.x): examples/watch/service/notify/main.go#L44
exported type TestListener should have comment or be unexported
Run Revive Action (1.20.x): examples/watch/service/longpull/main.go#L52
should omit type uint64 from declaration of var index; it will be inferred from the right-hand side
Run Revive Action (1.20.x): examples/watchinstance/main.go#L18
should have a package comment
Run Revive Action (1.20.x): examples/watch/service/notify/main.go#L48
comment on exported method TestListener.OnServicesUpdate should be of the form "OnServicesUpdate ..."
Run Revive Action (1.20.x): examples/configuration/group/main.go#L18
should have a package comment
Run Revive Action (1.20.x): pkg/plugin/healthcheck/healthcheck.go#L78
comment on exported method DetectResultImp.GetCode should be of the form "GetCode ..."
Run Revive Action (1.20.x): examples/mock/main.go#L69
invalid file examples/mock/main.go: examples/mock/main.go:69:13: expected ';', found 0 (and 1 more errors)
Run Revive Action (1.20.x): pkg/plugin/common/plugin.go#L18
should have a package comment
Run Revive Action (1.20.x): examples/circuitbreaker/interface/consumer/main.go#L18
should have a package comment