Skip to content
revive

fix:修复路由匹配失败默认转为返回全部实例 #294

Sign in to view logs

fix:修复路由匹配失败默认转为返回全部实例

fix:修复路由匹配失败默认转为返回全部实例 #294

Triggered via pull request August 26, 2024 04:00
@chuntaojunchuntaojun
opened #216
chuntaojun:release-v1.5.x
Status Success
Total duration 1m 49s
Artifacts –

revive.yml

on: pull_request
Matrix: Run Revive Action
Fit to window
Zoom out
Zoom in

Annotations

66 warnings
Run Revive Action (1.17.x)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.17.x): pkg/plugin/weightadjuster/proxy.go#L18
should have a package comment
Run Revive Action (1.17.x): pkg/stat/plugin/plug.go#L29
type name will be used as plugin.PluginAPI by other packages, and that stutters; consider calling this API
Run Revive Action (1.17.x): pkg/stat/loadbalance/lb.go#L27
type name will be used as loadbalance.LoadBalanceGauge by other packages, and that stutters; consider calling this Gauge
Run Revive Action (1.17.x): plugin/circuitbreaker/common/half_open.go#L135
exported const ToClose should have comment (or a comment on this block) or be unexported
Run Revive Action (1.17.x): pkg/flow/detect/ticker.go#L111
context.Context should be the first parameter of a function
Run Revive Action (1.17.x): plugin/healthcheck/utils/detection_utils_test.go#L25
should not use dot imports
Run Revive Action (1.17.x): plugin/metrics/prometheus/reporter.go#L130
redundant if ...; err != nil check, just return error instead.
Run Revive Action (1.17.x): plugin/loadbalancer/hash/config.go#L18
should have a package comment
Run Revive Action (1.17.x): plugin/loadbalancer/common/half_open.go#L18
should have a package comment
Run Revive Action (1.17.x): plugin/localregistry/common/cache_persist.go#L82
redundant if ...; err != nil check, just return error instead.
Run Revive Action (1.16.x)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.16.x): benchmark/benchmain/main.go#L46
const operationRpcDirect should be operationRPCDirect
Run Revive Action (1.16.x): benchmark/benchmain/main.go#L47
const operationRpcNaming should be operationRPCNaming
Run Revive Action (1.16.x): benchmark/benchsimple/main.go#L71
var maxQps should be maxQPS
Run Revive Action (1.16.x): api_config.go#L111
comment on exported function NewConfigGroupAPIByConfig should be of the form "NewConfigGroupAPIByConfig ..."
Run Revive Action (1.16.x): test/common/constant.go#L21
exported const ConsumerSuitServerPort should have comment (or a comment on this block) or be unexported
Run Revive Action (1.16.x): plugin/loadbalancer/weightedrandom/wr.go#L65
parameter 'ignoreHalfOpen' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.16.x): test/common/constant.go#L41
exported var ServerSwitchSuitServerPort should have comment or be unexported
Run Revive Action (1.16.x): api_config.go#L122
comment on exported function NewConfigGroupAPIByFile should be of the form "NewConfigGroupAPIByFile ..."
Run Revive Action (1.16.x): plugin/loadbalancer/weightedrandom/wr.go#L18
should have a package comment
Run Revive Action (1.16.x): benchmark/benchsimple/main.go#L239
func runQpsLimitFeature should be runQPSLimitFeature
Run Revive Action (1.18.x)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.18.x): examples/watch/service/notify/main.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/activehealthcheck/main.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/watch/service/longpull/main.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/circuitbreaker/consumer/main.go#L18
should have a package comment
Run Revive Action (1.18.x): benchmark/benchmain/main.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/configuration/crud/main.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/circuitbreaker/provider/main.go#L17
should have a package comment
Run Revive Action (1.18.x): examples/configuration/fallback/main.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/configuration/encrypt/main.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/configuration/normal/main.go#L18
should have a package comment
Run Revive Action (1.15.x)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.15.x): benchmark/benchsimple/main.go#L71
var maxQps should be maxQPS
Run Revive Action (1.15.x): benchmark/benchsimple/main.go#L181
struct field maxQps should be maxQPS
Run Revive Action (1.15.x): benchmark/benchsimple/main.go#L239
func runQpsLimitFeature should be runQPSLimitFeature
Run Revive Action (1.15.x): pkg/plugin/configfilter/configfilter.go#L19
should have a package comment
Run Revive Action (1.15.x): benchmark/benchsimple/main.go#L414
var useQpsLimit should be useQPSLimit
Run Revive Action (1.15.x): pkg/model/pb/service.go#L428
method GetTtl should be GetTTL
Run Revive Action (1.15.x): pkg/model/pb/metric/code.go#L28
exported const ExecuteSuccess should have comment (or a comment on this block) or be unexported
Run Revive Action (1.15.x): pkg/plugin/loadbalancer/util.go#L25
parameter 'ctx' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.15.x): pkg/model/pb/validate.go#L79
func ConvertServerErrorToRpcError should be ConvertServerErrorToRPCError
Run Revive Action (1.15.x): pkg/plugin/location/proxy.go#L26
exported type Proxy should have comment or be unexported
Run Revive Action (1.19.x)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.19.x): pkg/model/pb/metric/code.go#L18
should have a package comment
Run Revive Action (1.19.x): pkg/model/pb/metric/code.go#L28
exported const ExecuteSuccess should have comment (or a comment on this block) or be unexported
Run Revive Action (1.19.x): plugin/loadbalancer/weightedrandom/wr.go#L18
should have a package comment
Run Revive Action (1.19.x): pkg/plugin/configfilter/configfilter.go#L19
should have a package comment
Run Revive Action (1.19.x): pkg/plugin/loadbalancer/loadbalancer.go#L18
should have a package comment
Run Revive Action (1.19.x): plugin/loadbalancer/weightedrandom/wr.go#L65
parameter 'ignoreHalfOpen' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.19.x): pkg/plugin/location/location.go#L18
should have a package comment
Run Revive Action (1.19.x): pkg/plugin/location/proxy.go#L26
exported type Proxy should have comment or be unexported
Run Revive Action (1.19.x): pkg/plugin/location/location.go#L27
exported const ProviderName should have comment (or a comment on this block) or be unexported
Run Revive Action (1.19.x): pkg/plugin/metrics/proxy.go#L18
should have a package comment
Run Revive Action (1.20.x)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.20.x): pkg/plugin/weightadjuster/proxy.go#L18
should have a package comment
Run Revive Action (1.20.x): plugin/loadbalancer/hash/config.go#L18
should have a package comment
Run Revive Action (1.20.x): plugin/loadbalancer/common/half_open.go#L18
should have a package comment
Run Revive Action (1.20.x): plugin/loadbalancer/weightedrandom/wr.go#L18
should have a package comment
Run Revive Action (1.20.x): plugin/loadbalancer/weightedrandom/wr.go#L65
parameter 'ignoreHalfOpen' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.20.x): plugin/servicerouter/filteronly/router.go#L68
parameter 'clusters' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.20.x): plugin/servicerouter/filteronly/router.go#L68
parameter 'routeInfo' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.20.x): pkg/plugin/location/location.go#L18
should have a package comment
Run Revive Action (1.20.x): plugin/servicerouter/filteronly/router.go#L18
should have a package comment
Run Revive Action (1.20.x): plugin/location/local/local.go#L18
should have a package comment