fix: UTF-8 validation of nested string slice in Parquet #21262
Merged
+23
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coastalwhite
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
fix
coastalwhite
force-pushed
the
fix/nested-string-slice-utf8-21202
branch
from
c8a6ce2 to
ca05c76
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21262 +/- ##
==========================================
- Coverage 79.87% 79.80% -0.08%
==========================================
Files 1596 1596
Lines 228468 228470 +2
Branches 2607 2607
==========================================
- Hits 182492 182333 -159
- Misses 45380 45541 +161
Partials 596 596 ☔ View full report in Codecov by Sentry. |
2 tasks
|
mind cutting 1.22.1 with this fix in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21202.