fix(python): Ensure write_excel
recognises the Array dtype and writes it out as a string
#20994
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function was written before we had the
Array
dtype and theis_nested()
method on the dtype class, so explicitly enumerated the dtypes that needed to be cast to string on sheet export - and therefore missedArray
.Now takes advantage of
.is_nested()
to guarantee that we consistently identify dtypes that Excel doesn't work with natively (List, Array, Struct).Also made a few micro-optimisations, eg:
df.height
instead oflen(df)
, anddf.width
instead oflen(df.columns)
. Note that we can make this change in more places, avoiding the indirect/function call - I'll follow up with a separate PR for that.