Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unsafe *_release functions #19554

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Oct 31, 2024

Rust now automatically does bounds checks in get_unchecked and similar unsafe functions (I checked for each I removed) so we no longer need these wrappers: rust-lang/rust#120594

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Oct 31, 2024
@orlp orlp changed the title chore: Remove get_unchecked_release chore: Remove unsafe *_release functions Oct 31, 2024
@ritchie46 ritchie46 merged commit 0e52706 into pola-rs:main Nov 1, 2024
18 of 20 checks passed
@c-peters c-peters added the accepted Ready for implementation label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants