-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): Add replace_all
expression to complement replace
#16557
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16557 +/- ##
==========================================
+ Coverage 81.47% 81.48% +0.01%
==========================================
Files 1412 1414 +2
Lines 185474 185579 +105
Branches 2996 3002 +6
==========================================
+ Hits 151119 151225 +106
+ Misses 33839 33837 -2
- Partials 516 517 +1 ☔ View full report in Codecov by Sentry. |
This should be added on the rust side as well. |
I'll add that when I'm making the breaking change to casting behavior for 1.0 - it'll be easier then! EDIT: I think I can do some of the work already, working on it... EDIT2: Nope, it's a hassle. Let's merge like this and I can do this without jumping through hoops to avoid breaking something. |
Ref #14302
Changes
replace_all
, which is exactly the same asreplace
was, with the exception that defaults to filling unmatched values with null.default
andreturn_dtype
parameters forreplace
.This should be followed up with a breaking change that makes sure
replace
always keeps the original data type, instead of casting to the supertype of the original and the new values.