Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Vulcanize upstream changes #2

Closed
wants to merge 1 commit into from
Closed

[WIP] Vulcanize upstream changes #2

wants to merge 1 commit into from

Conversation

Olshansk
Copy link
Member

A port of this PR

@i-norden
Copy link

Would appreciate it if you can retain Roy's commit history. Can have him re-open a PR here if that helps. Thanks!

@Olshansk
Copy link
Member Author

@i-norden When we get to the point of merging it in: 🤝

@Olshansk Olshansk mentioned this pull request May 20, 2023
Closed
15 tasks
@reviewpad reviewpad bot mentioned this pull request May 22, 2023
Merged
@h5law
Copy link
Collaborator

h5law commented May 23, 2023

@Olshansk @i-norden I will close this PR as I have opened another which retains the squashed commit history of Roy from the vulcanize repo with some modifications to make it mergeable 👍🏼

@h5law h5law closed this May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Olshansk @i-norden @h5law