Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: GetAllApplications sets the Pagination.Limit field to max #25

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

adshmh
Copy link
Contributor

@adshmh adshmh commented Nov 20, 2024

Summary

This PR fixed the GetAllApplications method to set the pagination limit to the maximum value allowed by the Cosmos SDK, to allow returning all onchain applications in a single call.

Issue

GetAllApplications method was only returning the default number of onchain apps in a single call, omitting the rest of the applications from the results.

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@adshmh adshmh added the bug Something isn't working label Nov 20, 2024
@adshmh adshmh self-assigned this Nov 20, 2024
@adshmh adshmh requested a review from red-0ne November 20, 2024 15:51
Copy link
Collaborator

@red-0ne red-0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adshmh adshmh merged commit 2b3d4ad into main Nov 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants