Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug, Testing] fix: app transfer module-integration test #980

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

bryanchriswhite
Copy link
Contributor

Summary

Remove problematic build constraint from app transfer test and dependencies.

Issue

A //go:build integration constraint was unintentionally left in a few files related to app transfer module-integration tests, causing them to be skipped in CI. As a result, they've fallen out of date.

  • #N/A

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@bryanchriswhite bryanchriswhite added application Changes related to the Application actor testing Test (or test utils) additions, fixes, improvements or other labels Dec 2, 2024
@bryanchriswhite bryanchriswhite self-assigned this Dec 2, 2024
@bryanchriswhite bryanchriswhite merged commit b41dbef into main Dec 2, 2024
11 checks passed
@bryanchriswhite bryanchriswhite deleted the fix/test/app-transfer branch December 2, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application Changes related to the Application actor testing Test (or test utils) additions, fixes, improvements or other
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants