Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Health] Ensure gateway module msg responses are non-empty #972

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Dec 1, 2024

Summary

Ensure all supplier module msg responses are non-empty. This adds an Gateway field to the following protobuf type(s), and updates the unit tests to assert for presence and correctness.

  • MsgUnstakeGatewayResponse

Issue

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@bryanchriswhite bryanchriswhite added on-chain On-chain business logic code health Cleans up some code consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. labels Dec 1, 2024
@bryanchriswhite bryanchriswhite self-assigned this Dec 1, 2024
@bryanchriswhite bryanchriswhite added the gateway Changes related to the Gateway actor label Dec 1, 2024
@bryanchriswhite bryanchriswhite changed the title chore: ensure gateway module msg responses are non-empty [Code Health] Ensure gateway module msg responses are non-empty Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Cleans up some code consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. gateway Changes related to the Gateway actor on-chain On-chain business logic
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

1 participant