Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add consensus breaking warning #884

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

[CI] Add consensus breaking warning #884

wants to merge 9 commits into from

Conversation

okdas
Copy link
Member

@okdas okdas commented Oct 15, 2024

Summary

Notify when there's a consensus-breaking change.

Issue

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@okdas okdas added the tooling Tooling - CLI, scripts, helpers, off-chain, etc... label Oct 15, 2024
@okdas okdas self-assigned this Oct 15, 2024
@okdas okdas marked this pull request as ready for review October 17, 2024 21:53
@okdas okdas marked this pull request as draft October 17, 2024 23:51
@@ -657,11 +661,12 @@ func calculateGlobalPerClaimMintInflationFromSettlementAmount(settlementCoin sdk
// TODO_MAINNET: Consider using fixed point arithmetic for deterministic results.
settlementAmtFloat := new(big.Float).SetUint64(settlementCoin.Amount.Uint64())
newMintAmtFloat := new(big.Float).Mul(settlementAmtFloat, big.NewFloat(MintPerClaimedTokenGlobalInflation))
// DEV_NOTE: If new mint is less than 1 and more than 0, ceil it to 1 so that
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we know from the recent release, this changes gas calculation for example.

@okdas
Copy link
Member Author

okdas commented Nov 19, 2024

Will pick this up in the future iterations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Tooling - CLI, scripts, helpers, off-chain, etc...
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

1 participant