Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add msgstake_flow.md #1544

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Add msgstake_flow.md #1544

merged 1 commit into from
Apr 12, 2023

Conversation

msmania
Copy link
Contributor

@msmania msmania commented Apr 7, 2023

No description provided.

@msmania msmania requested a review from Olshansk April 7, 2023 03:39
@reviewpad
Copy link

reviewpad bot commented Apr 7, 2023

AI-Generated Summary: This pull request adds a new file msgstake_flow.md to the doc/specs directory. The file contains a flowchart illustrating how a MsgStake is handled by key functions when changing a staked node's output address. It describes the rules and conditions for a transaction to be accepted or rejected by the blockchain.

doc/specs/msgstake_flow.md Outdated Show resolved Hide resolved
doc/specs/msgstake_flow.md Outdated Show resolved Hide resolved
doc/specs/msgstake_flow.md Outdated Show resolved Hide resolved
doc/specs/msgstake_flow.md Outdated Show resolved Hide resolved
doc/specs/msgstake_flow.md Outdated Show resolved Hide resolved
doc/specs/msgstake_flow.md Outdated Show resolved Hide resolved
doc/specs/msgstake_flow.md Outdated Show resolved Hide resolved
@msmania msmania force-pushed the toshi/add-msgstake_chart.md branch from b00fa21 to 611a93c Compare April 12, 2023 00:25
@reviewpad
Copy link

reviewpad bot commented Apr 12, 2023

AI-Generated Summary: This pull request introduces a new document, msgstake_flow.md, to the repository. The document describes the journey of changing a node's output address and outlines the different functions, validations, and key steps involved in the process. It includes illustrations in the form of flowcharts to provide a better understanding of the whole procedure.

Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THIS IS SO GOOD!!! 🙏 🙏 🙏 🙏

@msmania msmania merged commit b8b1aa0 into staging Apr 12, 2023
@msmania msmania deleted the toshi/add-msgstake_chart.md branch April 12, 2023 00:48
@msmania
Copy link
Contributor Author

msmania commented Apr 12, 2023

I feel this is an excessive effort, but yeah, it looks much better and hopefully this helps someone. Thank you for your thorough review as always!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants