Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend CaseIterableRawRepresentable to FixedWidthInteger #277

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Extend CaseIterableRawRepresentable to FixedWidthInteger #277

merged 1 commit into from
Feb 20, 2023

Conversation

ytyubox
Copy link
Contributor

@ytyubox ytyubox commented Jan 13, 2023 •
edited
Loading

#276

Hi @ytyubox, good catch!

Rather than making the initializer public, what if we made the parser work with all FixedWidthInteger types? Then we could all the various integer types.

If you have the time you want to open a PR to do that? If not we can take care of it.

mbrandonw
mbrandonw approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@mbrandonw mbrandonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mbrandonw mbrandonw merged commit eaddc57 into pointfreeco:main Feb 20, 2023
@ytyubox ytyubox deleted the patch-1 branch February 21, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrandonw mbrandonw mbrandonw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ytyubox @mbrandonw