Add update; fix ambiguity #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
commented
Feb 28, 2019
| @@ -14,7 +14,7 @@ | |||
| buildForAnalyzing = "YES"> | |||
| <BuildableReference | |||
| BuildableIdentifier = "primary" | |||
| BlueprintIdentifier = "NT_8274405197546C7088976F7D3DDE8DF1" | |||
| BlueprintIdentifier = "C986EA57938522DE23E8CA570CCC6C80" | |||
There was a problem hiding this comment.
I updated XcodeGen...
stephencelis
commented
Feb 28, 2019
Sources/Overture/KeyPath.swift
Outdated
| @@ -117,10 +118,11 @@ public func mprop<Root, Value>( | |||
| /// - update: An update function for a given value. | |||
| /// - Returns: A reference-mutable setter function. | |||
| public func mver<Root, Value>( | |||
| _ keyPath: ReferenceWritableKeyPath<Root, Value>, | |||
| reference keyPath: ReferenceWritableKeyPath<Root, Value>, | |||
There was a problem hiding this comment.
This one overload of mver from a reference to a reference causes ambiguity with the inout version when using inline closures...
stephencelis
commented
Feb 28, 2019
| @@ -52,11 +52,28 @@ public func mver<S, A>( | |||
| /// - setter: A reference-mutable setter function. | |||
| /// - f: A mutable value transform function. | |||
| /// - Returns: A reference-mutable root transform function. | |||
| public func mver<S: AnyObject, A>( | |||
There was a problem hiding this comment.
I think trailing where is preferred now...
stephencelis
commented
Feb 28, 2019
Sources/Overture/With.swift
Outdated
| @@ -18,8 +18,18 @@ public func with<A, B>(_ a: A, _ f: (A) throws -> B) rethrows -> B { | |||
| /// - a: A mutable value. | |||
| /// - f: An in-out function. | |||
| /// - Note: This function is commonly seen in operator form as "pipe-forward", `|>`. | |||
| public func with<A>(_ a: inout A, _ f: (inout A) throws -> Void) rethrows { | |||
| try f(&a) | |||
| public func update<A>(_ a: inout A, _ fs: ((inout A) -> Void)...) { | |||
There was a problem hiding this comment.
with is now just for (A, (A) -> B) -> B.
stephencelis
commented
Feb 28, 2019
Sources/Overture/With.swift
Outdated
| @@ -43,7 +66,20 @@ public func with<A>(_ a: A, _ f: (inout A) throws -> Void) rethrows -> A { | |||
| /// - Returns: The result of `f` applied to `a`. | |||
| /// - Note: This function is commonly seen in operator form as "pipe-forward", `|>`. | |||
| @discardableResult | |||
| public func with<A: AnyObject>(_ a: A, _ f: (A) throws -> Void) rethrows -> A { | |||
| try f(a) | |||
| public func update<A: AnyObject>(reference a: A, _ fs: ((A) -> Void)...) -> A { | |||
There was a problem hiding this comment.
This overload is also for fixing ambiguity with the inout version when using inline closures...
|
@mbrandonw Do you have a better idea for naming those reference overloads?
|
mbrandonw
approved these changes
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #30, though let's discuss naming...