-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@_implementationOnly import UIKitNavigationShim #225
@_implementationOnly import UIKitNavigationShim #225
Conversation
This resolves some `missing required module 'UIKitNavigationShim'` errors when consuming this library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, great find @TobiasRe! I have confirmed this works too, and so I have also added a new CI test that builds a dynamic framework to make sure we don't break this in the future. Thanks!
@stephencelis Thanks for reaching out. So I guess we will have to stick to |
@stephencelis Do you mind creating a patch release to include this change? |
@TobiasRe Oops, we lost track of that. Just released 2.2.1! |
Background
When consuming this library there are some rare cases where Xcode fails to build a project with
missing required module 'UIKitNavigationShim'
errors.This can occur in frameworks and libraries that don't link
swift-navigation
orswift-composable-architecture
itself.Since
UIKitNavigationShim
is only used as an internal target when can safely import it as@_implementationOnly
to resolve this issue.Changes
@_implementationOnly
Fixes pointfreeco/swift-composable-architecture#3352