Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefix extension properties #211

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

yliu342
Copy link
Contributor

@yliu342 yliu342 commented Aug 22, 2024

Based on the discussion in #204 Adding _UIKitNavigation_ prefix to all the UIViewController extension properties.

@stephencelis
Copy link
Member

Looks like CI failed:

Value of type 'NavigationStackController' has no member 'hasViewAppeared'

I think from this line:

await assertEventuallyEqual(nav.hasViewAppeared, true)

Can you update that line and hopefully things will be green?

@yliu342
Copy link
Contributor Author

yliu342 commented Aug 22, 2024

Ha I forgot to run the example test cases... But luckily it helped to find a typo which can cause a run time crash

Copy link
Member

@mbrandonw mbrandonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @yliu342! Thanks for helping us with this.

@mbrandonw mbrandonw merged commit 75925ff into pointfreeco:main Aug 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants