Add ids to second occurrence of a type within a dump

[tahirmt]

Adding a unique id for occurrences of the same type.

Motivation

• Whenever the same object is repeated within a dump it gets completely redacted. This is done to avoid recursion but it can also mean that if there is the same object the appears multiple times for other reasons it still gets redacted
• If there is a repetition of multiple objects of the same type it removes the information about which object it is in the redacted state
• By assigning an id to each second or more occurrence of the same type we can identify which object it is easily

[stephencelis]

This is definitely an improvement! Brandon and I will look at this and maybe bikeshed some formatting details on Monday.

[stephencelis]

One thought (suggested by Brandon) is to maybe use # instead of <> to avoid clashing with generic parameter list syntax:

Suggested change

	return id > 1 ? "<\(id)>" : ""
	return id > 1 ? "#\(id)" : ""

Thoughts? Any concerns with such a change?

[tahirmt]

I think this makes sense

[tahirmt]

Done

[stephencelis]

Looks good! Just one change we'd like to consider.