Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve object diffing tools #111

Merged
merged 20 commits into from
Mar 12, 2024
Merged

Improve object diffing tools #111

merged 20 commits into from
Mar 12, 2024

Conversation

stephencelis
Copy link
Member

This PR:

  • Updates the diff function to track particular objects by identity
  • Updates the _DiffableObject protocol to work with value types assuming an object identifier is available. This allows a wrapper around an object to be used as the source of the diff, which is useful for TCA's upcoming Shared type, which can use dynamic member lookup to project into a smaller part of a type

@stephencelis stephencelis requested a review from mbrandonw March 8, 2024 18:35
@stephencelis stephencelis merged commit f01efb2 into main Mar 12, 2024
6 checks passed
@stephencelis stephencelis deleted the diffable-object-2 branch March 12, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants