Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @ViewBuilder to NavigationStack root view #3493

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

joshrl
Copy link
Contributor

@joshrl joshrl commented Nov 14, 2024

Adding view builder annotation to NavigiationStack. init. This matches the functionality of the built in initializer's root view. See #3483

Note that I'm not sure if there is a way to add a test for this exactly, but what I did to confirm was to modify NavigationDemoView in SwiftUICaseStudies locally (not checked in) like so:

  var body: some View {
    NavigationStack(path: $store.scope(state: \.path, action: \.path)) {
      Text("Fred")
      Form {
        Section { Text(template: readMe) }
      ...
Screenshot 2024-11-13 at 9 24 19 PM

Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephencelis stephencelis merged commit 333aa22 into pointfreeco:main Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants