Skip to content
This repository has been archived by the owner on Dec 15, 2018. It is now read-only.

Added support for Google Two Factor Auth #177

Closed
wants to merge 6 commits into from
Closed

Added support for Google Two Factor Auth #177

wants to merge 6 commits into from

Conversation

ezcGman
Copy link
Contributor

@ezcGman ezcGman commented Jan 10, 2017

The Google Auth module is missing support for Two Factor Auth. If your account has it enabled, you would simply get the standard error which would lead the user thinking his email/password combination was wrong. With this special exception you can catch that and display a proper error message that the user needs to make use of Google App Passwords: https://support.google.com/accounts/answer/185833?hl=en&ctx=ch_b%2F0%2FSmsAuthSettings

Copy link
Contributor

@nullpixel nullpixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for contributing!

@ezcGman
Copy link
Contributor Author

ezcGman commented Jan 23, 2017

Of course! Thanks for merging! :)

@n2o
Copy link

n2o commented Feb 28, 2017

Thanks for this pull request! It fixes my problem and I am now able to login again. Currently I am referencing to your personal repository for the latest version, until this has been merged.

@nullpixel
Copy link
Contributor

Closing, since all it does is add an exception. Thanks for contributing nonetheless

@ezcGman
Copy link
Contributor Author

ezcGman commented Mar 29, 2017

It also adds a check for this and returns this exception with the redirect URL included.
I would appreciate if you merge and commit it, as this is the only way to inform users with 2fa that they need an app password

@nullpixel nullpixel reopened this Mar 29, 2017
@j16sdiz
Copy link

j16sdiz commented Apr 3, 2017

This should be rebased before merging.

Copy link
Contributor

@ZeChrales ZeChrales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be rebased

@ezcGman
Copy link
Contributor Author

ezcGman commented Jun 29, 2017

Is there anything I need to do here?
Afaik you can rebase when merging this; I actually also have no idea how rebase works; never done. So if you want me to do it, any help would be appreciated!

@ezcGman
Copy link
Contributor Author

ezcGman commented Jul 5, 2017

Again: Anything I can do here? If I should rebase this, would appreciate some guidance what to actually do, as I'm unexperienced with rebase :) Thanks!

@ezcGman
Copy link
Contributor Author

ezcGman commented Jul 14, 2017

Closed as this should go into develop. Created new PR for this: #213

@ezcGman ezcGman closed this Jul 14, 2017
@krohne
Copy link

krohne commented Nov 1, 2017

Reopen? I'm getting RPC 100 on master branch at 2017-OCT-11 commit. Using an hash key I just bought, and a new app password, just in case.

@ZeChrales
Copy link
Contributor

Hi khrone you need to use /develop for now.

@krohne
Copy link

krohne commented Nov 1, 2017

Now getting a 403 error from Google login, even with a new app password (twice). Tried API versions 6702, 6900, 7100, and 7500. Is there a magic API version number that works on dev branch?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

6 participants