-
Notifications
You must be signed in to change notification settings - Fork 472
Added support for Google Two Factor Auth #177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for contributing!
Of course! Thanks for merging! :) |
Thanks for this pull request! It fixes my problem and I am now able to login again. Currently I am referencing to your personal repository for the latest version, until this has been merged. |
Closing, since all it does is add an exception. Thanks for contributing nonetheless |
It also adds a check for this and returns this exception with the redirect URL included. |
This should be rebased before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be rebased
Is there anything I need to do here? |
Again: Anything I can do here? If I should rebase this, would appreciate some guidance what to actually do, as I'm unexperienced with rebase :) Thanks! |
Closed as this should go into develop. Created new PR for this: #213 |
Reopen? I'm getting RPC 100 on master branch at 2017-OCT-11 commit. Using an hash key I just bought, and a new app password, just in case. |
Hi khrone you need to use /develop for now. |
Now getting a 403 error from Google login, even with a new app password (twice). Tried API versions 6702, 6900, 7100, and 7500. Is there a magic API version number that works on dev branch? |
The Google Auth module is missing support for Two Factor Auth. If your account has it enabled, you would simply get the standard error which would lead the user thinking his email/password combination was wrong. With this special exception you can catch that and display a proper error message that the user needs to make use of Google App Passwords: https://support.google.com/accounts/answer/185833?hl=en&ctx=ch_b%2F0%2FSmsAuthSettings