fix: use minikube cli to start/stop cluster

src/extension.spec.ts

@@ -31,6 +31,15 @@ vi.mock('@podman-desktop/api', async () => {
     containerEngine: {
       listContainers: vi.fn(),
     },
+
+    process: {
+      exec: vi.fn(),
+      env: {},
+    },
+
+    env: {
+      isMac: false,
+    },
   };
 });
 
@@ -57,3 +66,52 @@ test('check we received notifications ', async () => {
   expect(callbackCalled).toBeTruthy();
   expect(listContainersMock).toBeCalledTimes(1);
 });
+
+test('verify that the minikube cli is used to start/stop the minikube container', async () => {
+  const onDidUpdateContainerConnectionMock = vi.fn();
+  (podmanDesktopApi.provider as any).onDidUpdateContainerConnection = onDidUpdateContainerConnectionMock;
+
+  const listContainersMock = vi.fn();
+  (podmanDesktopApi.containerEngine as any).listContainers = listContainersMock;
+  listContainersMock.mockResolvedValue([
+    {
+      Labels: {
+        'name.minikube.sigs.k8s.io': 'minikube',
+      },
+      State: 'stopped',
+      Ports: [],
+      engineType: 'podman',
+      engineId: 'engine',
+      Id: '1',
+    } as unknown as podmanDesktopApi.ContainerInfo,
+  ]);
+
+  onDidUpdateContainerConnectionMock.mockImplementation((callback: any) => {
+    callback();
+  });
+
+  const connections: podmanDesktopApi.KubernetesProviderConnection[] = [];
+  const fakeProvider = {
+    registerKubernetesProviderConnection: vi
+      .fn()
+      .mockImplementation((connection: podmanDesktopApi.KubernetesProviderConnection) => {
+        connections.push(connection);
+      }),
+  } as unknown as podmanDesktopApi.Provider;
+  const mockExec = vi.spyOn(podmanDesktopApi.process, 'exec');
+  refreshMinikubeClustersOnProviderConnectionUpdate(fakeProvider);
+
+  await vi.waitUntil(() => connections.length > 0, { timeout: 5000 });
+
+  await connections[0].lifecycle.start?.({} as unknown as podmanDesktopApi.LifecycleContext);
+
+  expect(mockExec).toBeCalledWith(undefined, ['start', '--profile', 'minikube'], expect.any(Object));
+
+  await connections[0].lifecycle.stop?.({} as unknown as podmanDesktopApi.LifecycleContext);
+
+  expect(mockExec).toBeCalledWith(
+    undefined,
+    ['stop', '--profile', 'minikube', '--keep-context-active'],
+    expect.any(Object),
+  );
+});

src/extension.ts

@@ -109,16 +109,21 @@ async function updateClusters(provider: extensionApi.Provider, containers: exten
       const lifecycle: extensionApi.ProviderConnectionLifecycle = {
         start: async (): Promise<void> => {
           try {
-            // start the container
-            await extensionApi.containerEngine.startContainer(cluster.engineId, cluster.id);
+            const env = Object.assign({}, process.env);
+            env.PATH = getMinikubePath();
+            await extensionApi.process.exec(minikubeCli, ['start', '--profile', cluster.name], { env });
           } catch (err) {
             console.error(err);
             // propagate the error
             throw err;
           }
         },
         stop: async (): Promise<void> => {
-          await extensionApi.containerEngine.stopContainer(cluster.engineId, cluster.id);
+          const env = Object.assign({}, process.env);
+          env.PATH = getMinikubePath();
+          await extensionApi.process.exec(minikubeCli, ['stop', '--profile', cluster.name, '--keep-context-active'], {
+            env,
+          });
         },
         delete: async (logger): Promise<void> => {
           const env = Object.assign({}, process.env);