Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: create gha workflow to automate minikube e2e tests on windows #272

Conversation

amisskii
Copy link
Contributor

@amisskii amisskii commented Dec 2, 2024

issue: #240

@amisskii amisskii requested review from benoitf and a team as code owners December 2, 2024 10:29
@amisskii amisskii requested review from dgolovin and axel7083 and removed request for a team December 2, 2024 10:29
@amisskii amisskii force-pushed the automating-minikube-e2e-test-scenario-windows branch from 96bbbc5 to ccd7f55 Compare December 2, 2024 10:31
@amisskii amisskii marked this pull request as draft December 2, 2024 10:35
Signed-off-by: Anton Misskii <[email protected]>
@amisskii amisskii marked this pull request as ready for review December 2, 2024 11:17
Signed-off-by: Anton Misskii <[email protected]>
with:
name: results-e2e-${{ matrix.windows-version }}${{ matrix.windows-featurepack }}
path: |
results/*
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new line at EOF.

fail_on_failure: true
include_passed: true
detailed_summary: true
require_tests: true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add annotate_only: true

windows:
name: windows-${{ matrix.windows-version }}-${{ matrix.windows-featurepack }}
runs-on: ubuntu-latest
permissions:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with annotate_only is this not necessary.

Signed-off-by: Anton Misskii <[email protected]>
@amisskii amisskii merged commit 05bb800 into podman-desktop:main Dec 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automating the Minikube extension installation e2e test scenario on Mac
2 participants