feat: adding select version function #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: axel7083 <[email protected]>
benoitf
reviewed
Oct 18, 2024
src/download.ts
Outdated
Comment on lines
77
to
79
| if (cliInfo) { | ||
| lastReleasesMetadata = lastReleasesMetadata.filter(release => release.tag.slice(1) !== cliInfo.version); | ||
| } |
There was a problem hiding this comment.
does it work with cliInfo?.version (no usage of the if)
There was a problem hiding this comment.
Humm, yes but we avoid having to O(n) with the if
Co-authored-by: Florent BENOIT <[email protected]> Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
benoitf
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #171. Given the podman desktop core api, we need to have a function handling the user selection for the version to install.
To be able to provide the
CliToolInstaller#selectversion1 function, we need to have the quick pick logic. As recommended in #171 (comment) making the logic part of the minikubeDownload as it need the object to collect the releases.Footnotes
https://podman-desktop.io/api/interfaces/CliToolInstaller#selectversion ↩