Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add linux VM experimental support #1102

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

cdrage
Copy link
Contributor

@cdrage cdrage commented Dec 16, 2024

feat: add linux VM experimental support

What does this PR do?

  • Adds ability to test out VM for Linux users
  • Arm and AMD64 support.
  • Requires QEMU installed (there are prereqs as well as documentation
    that outlines it)

Screenshot / video of UI

Screenshot from 2024-12-16 13-10-31

What issues does this PR fix or reference?

Closes #878

How to test this PR?

  1. Be on Linux
  2. Install QEMU (see documentation)
  3. Build an image
  4. Click on the Virtual Machine tab after building (or the Launch VM
    button).

Signed-off-by: Charlie Drage [email protected]

@cdrage cdrage requested a review from a team as a code owner December 16, 2024 18:13
@cdrage cdrage requested review from dgolovin, jeffmaury and axel7083 and removed request for a team December 16, 2024 18:13
### What does this PR do?

* Adds ability to test out VM for Linux users
* Arm and AMD64 support.
* Requires QEMU installed (there are prereqs as well as documentation
  that outlines it)

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#878

### How to test this PR?

<!-- Please explain steps to reproduce -->

1. Be on Linux
2. Install QEMU (see documentation)
3. Build an image
4. Click on the Virtual Machine tab after building (or the Launch VM
   button).

Signed-off-by: Charlie Drage <[email protected]>
@jeffmaury
Copy link
Contributor

Can't test it on my Fedora VM got a blank page for the bootc webview but same on main

@cdrage
Copy link
Contributor Author

cdrage commented Dec 17, 2024

Can't test it on my Fedora VM got a blank page for the bootc webview but same on main

May have to do a pnpm install ? If same on main page could be problem non-related to PR.

@jeffmaury
Copy link
Contributor

Can't test it on my Fedora VM got a blank page for the bootc webview but same on main

May have to do a pnpm install ? If same on main page could be problem non-related to PR.

Yes and pnpm build as well but not related to this PR

@cdrage
Copy link
Contributor Author

cdrage commented Dec 17, 2024

Can't test it on my Fedora VM got a blank page for the bootc webview but same on main

May have to do a pnpm install ? If same on main page could be problem non-related to PR.

Yes and pnpm build as well but not related to this PR

I've pushed the extension to git.k8s.land/cdrage/bootc-extension please install it via that link and try again

@deboer-tim
Copy link
Contributor

deboer-tim commented Dec 17, 2024

Found the issue, vite was bumped from 5.4.11 to 6.0.0 on Nov 26th, but vite-plugin-svelte needs to go from 4.0 to 5.0 at the same time and that PR (#1091) was held up due to test failure. So just need to find the fix and merge #1091, it's unrelated to this PR.

@benoitf
Copy link
Contributor

benoitf commented Dec 17, 2024

e2e are passing so it looks like vite is able to build the app no ? (or it means e2e are not testing the current PR code)

@deboer-tim
Copy link
Contributor

e2e are passing so it looks like vite is able to build the app no ? (or it means e2e are not testing the current PR code)

Yes, app can build fine and tests pass. Just harder to test since it won't start in dev:

  • vite 6 + vitest 2 (main/current state) - tests pass but fails to load in Podman Desktop using pnpm watch
  • vite 6 + vitest 3-beta.1 - tests pass but then test process crashes, pnpm watch is fine
  • vite 6 + vitest 3-beta.2 - new test fail, pnpm watch is fine

So this PR is ok, can be tested via Charlie's build or by backing out vite update locally. Suggest we use #1107 to resolve the vite/vitest issue.

@cdrage cdrage merged commit bc9a3ea into podman-desktop:main Dec 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux support for launching test VM
4 participants