chore: remove hvf acceleration from amd64 vm command #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What does this PR do? Should not have been added / was added when refactoring. `hvf` should not be there for amd64 as it's cross-arch and not compatible (hvf only working for arm). ### Screenshot / video of UI <!-- If this PR is changing UI, please include screenshots or screencasts showing the difference --> N/A ### What issues does this PR fix or reference? <!-- Include any related issues from Podman Desktop repository (or from another issue tracker). --> Fixes podman-desktop#1088 ### How to test this PR? <!-- Please explain steps to reproduce --> 1. Create an amd64 image 2. Run VM tab 3. Works / runs. Signed-off-by: Charlie Drage <[email protected]>
cdrage
requested review from
benoitf,
axel7083 and
gastoner
and removed request for
a team
deboer-tim
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: remove hvf acceleration from amd64 vm command
What does this PR do?
Should not have been added / was added when refactoring.
hvfshouldnot be there for amd64 as it's cross-arch and not compatible (hvf only
working for arm).
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
Fixes #1088
How to test this PR?
Signed-off-by: Charlie Drage [email protected]