VBLOCKS-1301 Support node versions 16 and above. (twilio#169)

* VBLOCKS-1301 Support node versions 16 and above.
* VBLOCKS-1301 Removing --legacy-peer-deps flag from circleci jobs.
* VBLOCKS-1301 Updating package "twilio" to 3.84.1, which does not depend on express. Hence, no need to add the "types" config to the TypeScript compiler.

.circleci/config.yml

@@ -64,7 +64,7 @@ commands:
           key: dependency-cache-{{ checksum "package.json" }}
       - run:
           name: Installing dependencies
-          command: node -v && npm install --legacy-peer-deps
+          command: node -v && npm install
       - save_cache:
           key: dependency-cache-{{ checksum "package.json" }}
           paths:

.circleci/images/docker-compose.yml

@@ -30,7 +30,7 @@ services:
       - /opt/app/node_modules
   integrationTests: # runs integration tets. Expects that sources are mounted.
     <<: *runtimeDefaults
-    command: bash -c "npm install --legacy-peer-deps && npm run build && ls -la /root && ls -la /root/.npm && npm run test:network"
+    command: bash -c "npm install && npm run build && ls -la /root && ls -la /root/.npm && npm run test:network"
   bash: # runs bash shell inside container. helpful for debugging
     <<: *runtimeDefaults
     command: bash

CHANGELOG.md

@@ -4,6 +4,7 @@
 Changes
 -------
 
+- The SDK now builds on NodeJS versions 16 and above without the `--legacy-peer-deps` flag.
 - Removed usage of NodeJS modules from the SDK and some dependencies. With this change, the SDK should now work with some of the latest frameworks that use the latest versions of bundlers such as Vite and Webpack.
 - Removed unnecessary files from the generated npm package.
 - Links to source maps are now included in the generated npm package.

lib/twilio/errors/generated.ts

@@ -2,8 +2,7 @@
 /**
  * @packageDocumentation
  * @module Voice
- * @publicapi
- * @internal
+ * @internalapi
  */
 
 /**

lib/twilio/statsMonitor.ts

@@ -170,7 +170,7 @@ class StatsMonitor extends EventEmitter {
   /**
    * The setInterval id for fetching samples.
    */
-  private _sampleInterval: NodeJS.Timer;
+  private _sampleInterval?: NodeJS.Timer;
 
   /**
    * Keeps track of supplemental sample values.
@@ -232,9 +232,10 @@ class StatsMonitor extends EventEmitter {
    * @returns The current {@link StatsMonitor}.
    */
   disable(): this {
-    clearInterval(this._sampleInterval);
-    delete this._sampleInterval;
-
+    if (this._sampleInterval) {
+      clearInterval(this._sampleInterval);
+      delete this._sampleInterval;
+    }
     return this;
   }