VBLOCKS-1155 Make sure publisher host is inited if home region exists (…

…twilio#122)

* VBLOCKS-1155 Making sure publisher host is inited if home region is available

* Changelog and tests

CHANGELOG.md

@@ -1,3 +1,11 @@
+2.1.2 (In Progress)
+=========================
+
+Bug Fixes
+---------
+
+- Fixed an issue where insights data stops getting published after calling `device.updateOptions`.
+
 2.1.1 (February 18, 2022)
 =========================
 

lib/twilio/device.ts

@@ -1087,7 +1087,9 @@ class Device extends EventEmitter {
     const region = getRegionShortcode(payload.region);
     this._edge = payload.edge || regionToEdge[region as Region] || payload.region;
     this._region = region || payload.region;
+    this._home = payload.home;
     this._publisher?.setHost(createEventGatewayURI(payload.home));
+
     if (payload.token) {
       this._identity = payload.token.identity;
       if (
@@ -1105,7 +1107,6 @@ class Device extends EventEmitter {
         }, timeoutMs);
       }
     }
-    this._home = payload.home;
 
     const preferredURIs = getChunderURIs(
       this._edge as Edge,
@@ -1347,6 +1348,10 @@ class Device extends EventEmitter {
       publisherOptions.host = this._options.eventgw;
     }
 
+    if (this._home) {
+      publisherOptions.host = createEventGatewayURI(this._home);
+    }
+
     this._publisher = new (this._options.Publisher || Publisher)(PUBLISHER_PRODUCT_NAME, this.token, publisherOptions);
 
     if (this._options.publishEvents === false) {

tests/unit/device.ts

@@ -387,6 +387,12 @@ describe('Device', function() {
           assert.equal(device['_options'].appName, 'baz');
         });
 
+        it('should re-initialize publisher with the correct host', () => {
+          pstream.emit('connected', { home: 'foo'});
+          device.updateOptions({ appName: 'bar' });
+          assert.equal(Publisher.args[1][2].host, 'eventgw.foo.twilio.com');
+        });
+
         it('should set up an audio helper', () => {
           const spy = device['_setupAudioHelper'] = sinon.spy(device['_setupAudioHelper']);
           device.updateOptions({});