Feature/issue 42 Use time range in db query #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue: #42 - Change database query to use time range
Description
The query from the API to the DB wasn't using time, causing all times including those outside the range specified to be returned.
Overview of work done
Updated the keyconditionexpression to use the sort key to only return items between the start and end times specified. Changed datetime types to strings to support the dynamo query. Updated the API tests, fixed some linting.
Overview of verification done
Existing tests failed due to start and end times that were outside the test data. Updated the API tests and now unit tests pass.
Overview of integration done
Tests pass.
PR checklist:
See Pull Request Review Checklist for pointers on reviewing this pull request