fix(browser): when usingCustomGetBrowser is set, call getBrowser each time #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if using a custom browser, getBrowser is not called when "browser" is != null. As the behaviour of the browser instance is controlled outside, this leads to situation where a browser is closed, but penthouse believes the browser is still running.
|
Thanks for the fix! (The test error is unrelated, seems to fail intermittently since the last puppeteer upgrade - need to look into at some point) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if using a custom browser, getBrowser is not called when "browser" is != null. As the behaviour of the browser instance is controlled outside, this leads to situation where a browser is closed, but penthouse believes the browser is still running.