Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades #290

Merged
merged 4 commits into from
May 11, 2019
Merged

Upgrades #290

merged 4 commits into from
May 11, 2019

Conversation

pocketjoso
Copy link
Owner

@pocketjoso pocketjoso commented May 11, 2019

Babel 7 and eslint upgrades via @simllll and #287. Want to fix linting issue on master so merging here. Didn't go with prettier-standard in the .eslintrc in the end though, as it for some reason mandates not having any space between function name and parens, which I do prefer.

Puppeteer upgrade to 1.15, has been well tested at this point.

@pocketjoso pocketjoso merged commit 7270244 into master May 11, 2019
@pocketjoso pocketjoso deleted the upgrades branch May 11, 2019 10:15
@simllll
Copy link
Contributor

simllll commented May 11, 2019

Hi :) thanks for the update, regarding the formatting rule, there is a long discussion already on prettier itself. prettier/prettier#1139 (comment)

The reason why I used prettier-standard was because the rules conflicted beforehand, and probably do now still. E.g. I'm using webstorm and therefore it kept reformating the files during commit to a different style, which didn't comply with prettier afterwards. I would recommend either disabling prettier, and just use standard with e.g. eslint, or changing the style to prettiers opinionated one which has no whitespace between the function and parameters. If you like to,I can add eslint instead and make a PR?

@pocketjoso
Copy link
Owner Author

@simllll I experienced the same problem, but for me it was fixed when I added the indent: 0 rule in the .eslintrc:
f9ebbad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants