Merge pull request #345 from bv-sumit/sumit_page_goto_options

Fix #344 adding page goto options for puppeteer
pocketjoso · May 17, 2022 · 9982d51 · 9982d51
2 parents 765f485 + 3a7029a
commit 9982d51
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/examples/custom-browser.js b/examples/custom-browser.js
@@ -16,10 +16,12 @@ const browserPromise = puppeteer.launch({
   }
 })
 penthouse({
+	// pageGotoOptions are the options for puppeteer: Check the available options : https://github.com/puppeteer/puppeteer/blob/v14.0.0/docs/api.md#pagegotourl-options
   url: 'https://google.com',
   cssString: 'body { color: red }',
   puppeteer: {
-    getBrowser: () => browserPromise
+    getBrowser: () => browserPromise,
+    pageGotoOptions: {waitUntil: 'networkidle0'}
   }
 })
   .then(criticalCss => {

diff --git a/src/core.js b/src/core.js
@@ -24,13 +24,14 @@ function blockinterceptedRequests (interceptedRequest) {
 function loadPage (
   page,
   url,
+  pageGotoOptions,
   timeout,
   pageLoadSkipTimeout,
   allowedResponseCode
 ) {
   debuglog('page load start')
   let waitingForPageLoad = true
-  let loadPagePromise = page.goto(url)
+  let loadPagePromise = page.goto(url, pageGotoOptions)
   if (pageLoadSkipTimeout) {
     loadPagePromise = Promise.race([
       loadPagePromise,
@@ -267,6 +268,7 @@ async function grabPageScreenshot ({
 async function pruneNonCriticalCssLauncher ({
   pagePromise,
   url,
+  pageGotoOptions,
   cssString,
   width,
   height,
@@ -398,6 +400,7 @@ async function pruneNonCriticalCssLauncher ({
     const loadPagePromise = loadPage(
       page,
       url,
+      pageGotoOptions,
       timeout,
       pageLoadSkipTimeout,
       allowedResponseCode

diff --git a/src/index.js b/src/index.js
@@ -96,6 +96,7 @@ const generateCriticalCssWrapped = async function generateCriticalCssWrapped (
     formattedCss = await generateCriticalCss({
       pagePromise,
       url: options.url,
+      pageGotoOptions: (options.puppeteer && options.puppeteer.pageGotoOptions) || {},
       cssString: options.cssString,
       width,
       height,