Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove style named Global #1275

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Remove style named Global #1275

merged 1 commit into from
Oct 8, 2019

Conversation

veyndan
Copy link
Collaborator

@veyndan veyndan commented Oct 7, 2019

Explicitly setting the android:layout_width and android:layout_height to wrap_content is much more expressive than subclassing a style called Global which tells us nothing of value.

@Meisolsson Meisolsson merged commit 6ef8354 into pockethub:master Oct 8, 2019
@veyndan veyndan deleted the styles-Global branch October 8, 2019 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants