Fix issues loading fail #1164
Merged
Fix issues loading fail #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well it's probably better if we just don't pass null. I think the best fix here is to figure out why we passed null to it in the first place. Looking at it we could probably just pass an empty collection to as events instead of the null we are passing now. Regaring the issue being null that's more or a problem which I don't understand. Ther should be no way for an issue to be null in this case from what I know. |
plweegie
force-pushed
the
issue_load_fail
branch
from
144877e to
855b546
Compare
|
There was indeed a call when we passed null as events to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure whether that relates to #1100 or not, the description there was not clear enough.
This is something that I've discovered myself,
com.github.pockethub.android.ui.issue.IssueFragmentwas showing an error and an empty list due to null arguments being passed somewhere along the Rx workflow inrefreshIssue(). This has now been fixed.