Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix textarea enter keydown #1370

Merged
merged 2 commits into from
Dec 24, 2022

Conversation

tenthree
Copy link
Contributor

When a user types CJK characters and the IME show up, pressing ENTER to select a word will also trigger form submission(save changes) simultaneously; to avoid unexpected request submission, we could add the event.isComposing checking to resolve it, thx.

MDN references

pb

@ganigeorgiev
Copy link
Member

Thank you. I wasn't aware of IME and it specific events.

Could you pull the latest changes from master and rebuild the ui/dist?

@tenthree tenthree force-pushed the fix-textarea-enter-keydown branch from a8585b8 to af04554 Compare December 24, 2022 13:36
@ganigeorgiev ganigeorgiev merged commit d556105 into pocketbase:master Dec 24, 2022
@ganigeorgiev
Copy link
Member

I've squash merged it. The fix will be available with the next bugfix or v0.11.0 release (sometime next week or the week following it).

@tenthree
Copy link
Contributor Author

I've squash merged it. The fix will be available with the next bugfix or v0.11.0 release (sometime next week or the week following it).

No problem, thx.

abdokhaire pushed a commit to abdokhaire/postgresbase that referenced this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants