Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in ipix calculation? #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

curtcorum
Copy link

@curtcorum curtcorum commented Jan 15, 2019

Above unchanged code (i.e. without the commenting out) gives:
2 = xy2pix(1,1,1,1)
13 = xy2pix(1,1,1,12)
After edits (i.e. %ipix = ipix+1;) it gives:
1 = xy2pix(1,1,1,1)
12 = xy2pix(1,1,1,12)

Above unchanged code (i.e. without the commenting out) gives:
2 = xy2pix(1,1,1,1)
13 = xy2pix(1,1,1,12)
After edits (i.e. %ipix = ipix+1;) it gives:
1 = xy2pix(1,1,1,1)
12 = xy2pix(1,1,1,1)
@curtcorum curtcorum closed this Jan 15, 2019
@curtcorum curtcorum reopened this Jan 15, 2019
@pochoi
Copy link
Owner

pochoi commented Jan 18, 2019

Thanks for bringing it up!
Sorry I was working on other things so I did not have the time to look into it.
I bet that this line was meant to offset 0-based indexing in https://arxiv.org/pdf/astro-ph/0409513.pdf
I will help checking those formula this weekend!

@curtcorum curtcorum closed this Aug 9, 2020
@curtcorum curtcorum reopened this Aug 9, 2020
@curtcorum
Copy link
Author

@pochoi
Did you ever get a chance to review?
thanks,
Curt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants