(Fix) Disable continue button in step 1 if contracts couldn't be downloaded #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Black Duck Security ReportMerging #516 into master will decrease security risk! Removed ComponentsMedium Risk: 1 |
ghost
assigned 
vbaranov
reviewed
Jan 29, 2018
src/components/stepOne/index.js
Outdated
| console.error('Error downloading contracts', e) | ||
| toast.showToaster({ | ||
| type: TOAST.TYPE.ERROR, | ||
| message: 'The contracts could not be downloaded' |
There was a problem hiding this comment.
Maybe, to add "Please try to refresh the page. If the problem still persists, try again later".
vbaranov
approved these changes
Jan 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #399.
Disable the "Continue" button in step one until all the contracts are downloaded. If there is a problem with the download, the button is kept disabled and a toast message with an error is shown.
This will help with the problem in #399, but only when the ABI files are missing, because those are the ones that are
JSON.parsed. If the SOL and BIN files, the index.html is returned. I mean: a 404 error is never returned when a file inpublic/contractsis missing.I think this is configured that way for
react-routerto work in HTML5 mode. I don't really know how to fix that, but I think it's a different issue.