-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Refactor) Mobx state management #363
Conversation
Update Store Naming and Eject React
(Refactor) Update Home and stepOne
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me now
@fvictorio @fernandomg great job.
|
0.1 sounds good. I'll add some documentation in the wiki for new developers, but I don't think documenting the state structure is worth it: it's going to get old fast, and the MobX stores seem pretty self-documenting. What do you think? |
If you can document basic ideas of our state to new developers it would be great |
I agree with documenting of the structure. Day will come, when we'll forgot, where some properties for wizard are stored, if we won't describe it. |
I added a page to the wiki: https://github.com/oraclesorg/ico-wizard/wiki/Source-code-structure I didn't describe all stores because I think some of them should be replaced with local state. |
@fvictorio could we deploy it on stage server? At the moment the way we did it is to merge a PR into Do you have any other ideas for staging? |
No, that sounds perfect. I'll merge it on the |
Done, it is in the stage server now. I am testing it there. |
@fvictorio thank you, will test too @vbaranov Viktor, btw what was the idea behind syncing to branches using PRs? E.g. #368 |
It seems to be working fine. I tested crowdsales with token reservation, multiple tiers, whitelisting. |
Hi, what's the next step here? Do we leave it in stage some time more for testing or can we merge it into master? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested basic scenario on the staging server and it worked fine
Congrats everyone on PR merge! @fvictorio could you please create a tag and release the source code in it with brief description of MobX changes. |
Sure! |
This is a continuation of #304, with the merge conflicts resolved. I created a new PR because I can't push to @15chrjef repo.