Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) Toaster on contract download #340

Merged
merged 4 commits into from
Nov 6, 2017

Conversation

fernandomg
Copy link
Contributor

Closes #270

  • Added a toaster informing the user that the contract was properly downloaded on the PC.
  • Moved the Contract Download option after the last transaction, to avoid "Loading" overlay and "Toaster" overlapping.

alert-on-contract-download

@fernandomg
Copy link
Contributor Author

Depends on #336

Copy link
Contributor

@mark-antony1 mark-antony1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great feature. Few minor changes.

@@ -19,6 +20,11 @@ export class Invest extends React.Component {
state.loading = true;
state.pristineTokenInput = true;
this.state = state;

this.alertOptions = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extract to variable in constants file and import

const { PUBLISH } = NAVIGATION_STEPS

export class stepFour extends stepTwo {
constructor(props) {
super(props);
let oldState = getOldState(props, defaultState)
this.state = Object.assign({}, oldState)
this.alertOptions = { time: 10000, position: 'top right' }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extract and as variable to constant file

@@ -497,6 +498,8 @@ export class stepFour extends stepTwo {
transferOwnership(web3, this.state.contracts.token.abi, contracts.token.addr, this.state.crowdsale[0].walletAddress, 46699, (err) => {
if (err) return this.hideLoader();
this.hideLoader();
this.downloadCrowdsaleInfo();
this.showToaster({ message: 'A file with contracts and metadata downloaded on your computer' })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extract message to constant

(SYNC) toaster-on-contract-download <- master
@vbaranov vbaranov self-requested a review November 6, 2017 19:24
Copy link
Collaborator

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Constants are created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants