(Fix) Use web3 HttpProvider in dev environment #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use-web3-http-provider branch sync with master branch
(Sync) use-web3-http-provider <- master
mark-antony1
reviewed
Nov 4, 2017
src/utils/blockchainHelpers.js
Outdated
| @@ -38,6 +38,10 @@ export function getWeb3(cb) { | |||
| if (typeof web3 === 'undefined') { | |||
| // no web3, use fallback | |||
| console.error("Please use a web3 browser"); | |||
| if (process.env.NODE_ENV === 'development') { | |||
There was a problem hiding this comment.
Do you mean the condition in the if? Something like:
const devEnvironment = process.env.NODE_ENV === 'development'
if (devEnvironment) {
mark-antony1
reviewed
Nov 4, 2017
|
@15chrjef Change applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #324.
If web3 is not injected and you are in the
developmentenvironment (usingnpm start), try to connect directly to testrpc (localhost:8545).I think this can be very useful during development, since the transactions are submitted automatically.