Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Fix) token validation on invest button #321

Merged
merged 3 commits into from
Nov 2, 2017
Merged

(Fix) token validation on invest button #321

merged 3 commits into from
Nov 2, 2017

Conversation

fernandomg
Copy link
Contributor

Closes #273.

  • Added error message for token input.
  • On form submit, validates if the token is valid.

Prevents submission if token isn't valid, and displays an error message right after the input field.

prevent-invalid-token

@igorbarinov igorbarinov requested a review from vbaranov November 1, 2017 19:36
@vbaranov
Merge pull request #330 from oraclesorg/master
d4a562f 
(validation-on-invest-button branch) sync with master
@vbaranov
&.disabled is not used in css
82df45b
vbaranov
vbaranov approved these changes Nov 2, 2017
View reviewed changes
Copy link
Collaborator

@vbaranov vbaranov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted disabled css rule from this PR, because it is not used in it

@vbaranov vbaranov merged commit 35fbcf2 into master Nov 2, 2017
@fernandomg fernandomg deleted the validation-on-invest-button branch November 2, 2017 13:44
@fernandomg fernandomg restored the validation-on-invest-button branch November 2, 2017 14:48
@fernandomg fernandomg deleted the validation-on-invest-button branch November 2, 2017 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fernandomg @vbaranov