Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade of web3, bugs in deployContract, UI Fixes, Refactoring #234

Merged
merged 27 commits into from
Oct 7, 2017

Conversation

vbaranov
Copy link
Collaborator

@vbaranov vbaranov commented Oct 6, 2017

Change log:

  1. Migration from [email protected] to [email protected] (web3.toWei -> web3.utils.toWei, web3.fromWei -> web3.utils.fromWei, web3.isAddress -> web3.utils.isAddress, contract deployment, call of contract methods, sending of tx to contract, web3.eth.accounts -> web3.eth.getAccounts())
  2. Callback is fixed for deployContract function in stepFour\utils (doubled callback fix)
  3. Depreciated code is removed
  4. Twitter link is fixed in footer

Joined issue: #232
Possible joined issue: #206

Affected 3 end-users at least

Deposit event to buy method for bridge
Mention about ICO Wizard in the top of sources
ICO Wizard Bridge testing description
README update: Kovan verification
Bridge instruction update
Update bridge-side instruction
…ultiple transactions for crowdsale with reserved tokens fix
@vbaranov vbaranov requested a review from igorbarinov October 6, 2017 17:58
@igorbarinov igorbarinov self-assigned this Oct 6, 2017
@igorbarinov igorbarinov changed the title Users` bugs feedback Upgrade of web3, bugs in deployContract, UI Fixes, Refactoring Oct 6, 2017
@igorbarinov
Copy link
Member

I tested it on Stage server and had one issue with an exception in a contract and warning from metamask?
image

I recorded a video with my test, it's in the fifth minute.
https://youtu.be/N5mwzEiD7Tw?t=5m

@mark-antony1
Copy link
Contributor

How urgent is this? I would like to minimize the updates to code that touches 'state' until the new state management system is here.

@vbaranov
Copy link
Collaborator Author

vbaranov commented Oct 7, 2017

Fixes from this PR may affect end-users on production to solve their problems. IMHO, it is urgent.

@igorbarinov
Copy link
Member

I agree, let's merge it 💯

Copy link
Member

@igorbarinov igorbarinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on production and was successfully created an instance on Kovan. I think we should approve it and merge ASAP

Copy link
Contributor

@mark-antony1 mark-antony1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address this comment prior to merging. I approve this, but will need help merging this commit with the new state management system. Much of this commit is unclear to me.

@vbaranov
Copy link
Collaborator Author

vbaranov commented Oct 7, 2017

@15chrjef Thanks. I'll help you with manual merging for your PRs.

@vbaranov vbaranov merged commit 14e873e into master Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants