Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: merge package_manager with cli crate #51

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Aug 3, 2023

No description provided.

@anonrig anonrig requested a review from steveklabnik August 3, 2023 15:01
@anonrig anonrig mentioned this pull request Aug 3, 2023
@anonrig anonrig force-pushed the remove-package-manager-folder branch from 742899d to df9899a Compare August 3, 2023 15:05
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Merging #51 (7aa3b9a) into main (0a77c54) will increase coverage by 0.69%.
The diff coverage is 93.10%.

❗ Current head 7aa3b9a differs from pull request most recent head 4b6c3fc. Consider uploading reports for the commit 4b6c3fc to get more accurate results

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   81.06%   81.75%   +0.69%     
==========================================
  Files          21       21              
  Lines        1072     1069       -3     
==========================================
+ Hits          869      874       +5     
+ Misses        203      195       -8     
Files Changed Coverage Δ
crates/cli/src/bin/main.rs 0.00% <ø> (ø)
crates/cli/src/commands/mod.rs 44.00% <ø> (ø)
crates/cli/src/fs.rs 100.00% <ø> (ø)
crates/cli/src/package_manager.rs 88.88% <ø> (ø)
crates/cli/src/lib.rs 46.15% <60.00%> (+2.40%) ⬆️
crates/cli/src/commands/add.rs 98.00% <100.00%> (ø)
crates/cli/src/commands/install.rs 100.00% <100.00%> (ø)
crates/cli/src/package_import.rs 89.47% <100.00%> (ø)

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Benchmark Results

Linux

group                          main                                   pr
-----                          ----                                   --
tarball/download_dependency    1.03      9.3±0.57ms   465.0 KB/sec    1.00      9.1±0.42ms   479.1 KB/sec

@anonrig anonrig merged commit cee0637 into main Aug 3, 2023
@anonrig anonrig deleted the remove-package-manager-folder branch August 3, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants