Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

feat: add benchmark with lots of files #11

Merged
merged 1 commit into from
Oct 3, 2017
Merged

Conversation

zkat
Copy link
Contributor

@zkat zkat commented Oct 2, 2017

based on https://github.com/sciolist/fcopy/blob/c0ded8b82bbaa3f4cdb0a67e951eb3f8b0f97fb7/perf/project/alottafiles/package.json

Similar to #10 -- this is intended to provide a more realistic view of what a modern app will often look like. This specific package.json was the one used to benchmark Yarn's new fs.copyFile() feature, which sped things up quite a bit.

@zkat
Copy link
Contributor Author

zkat commented Oct 2, 2017

Oh yeah, probably want consent from @sciolist before actually merging this one. I'd previously gotten approval from @corbinu for #10, so I'm less worried about that one.

@zkochan
Copy link
Member

zkochan commented Oct 2, 2017

Should I run this on a COW filesystem? I'll have to check if my Windows/Linux support COW

@zkat
Copy link
Contributor Author

zkat commented Oct 2, 2017

@zkochan I feel like that's an extra dimension to the benchmarks, and CoW is still not exactly widespread on OSX and a lot of Linux systems. I think it's still worth keeping a non-CoW version around (or just do that by making the benchmarks be per-platform, and provide information on what each one does).

@BYK
Copy link

BYK commented Oct 2, 2017

It is important to note Node version too. copyFile is not available in earlier versions of node which makes a big difference.

@sciolist
Copy link

sciolist commented Oct 3, 2017

@zkat Absolutely fine with me.

@zkochan zkochan merged commit 71638d6 into pnpm:master Oct 3, 2017
@zkat zkat deleted the alotta-files branch October 3, 2017 22:57
@nikoladev nikoladev mentioned this pull request Oct 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants