Added additional settings.

[GuidoZam]

🎯 Aim

Added a new additional step setting when scaffolding a new project to specify if the node version manager configuration file should be created or not.

📷 Result

✅ What was done

• Added a new project additional step to create or not the node version manager configuration file.
• Added new VSCode setting createNodeVersionFileDefaultValue to define the default value of the new project additional step.
• Added new VSCode setting nodeVersionManagerFile to specify which configuration file to be created.

🔗 Related issue

Closes: #285

[Adam-it]

Awesome 🤩😍. I will review this ASAP

[Adam-it]

@GuidoZam Awesome work so far 👏👏👏👏👏. You Rock 🤩
I left a few comments. Please do give them a recheck.
When testing I also found some 2 strange behaviors we should fixup before we merge:

I don't know why but when I select creating nvm file together with other dependencies

it is set in the project.pnp file

but as a result in terminal I only get the nvm file installed no other npm install is running

I don't know why but this seem to be only like this when I have this new dependency set otherwise it works normally and installed everything so it seems like a bug

also
when you reset the create nvm file to default it will be set to true not false by default

most probably this is due to the fact that in package.json we set this a string "false" not false

[Adam-it]

@GuidoZam I also forgot to mention that we should update the readme part with additional step in scaffolding form to now include this new option as well together with screenshots

[GuidoZam]

Sure thing @Adam-it, I will check the possible bug and also update the documentation and get back to you when I have news.

[GuidoZam]

Hi @Adam-it, I verified and fixed all your reviews.
The two bugs are resolved:

• The first one I think was a different behavior produced by the custom name of the terminal. I've removed that customization and everything's seems to work fine.
• About the second bug you were right, it was just a type mistake, updating the package.json type resolved the issue.

I've also updated the README file, have a look and tell me if this way is ok for you. There are some new images and text for the Node version manager support (section 12 of the README).

About the data/sp-dev-fx-samples.json file I didn't update that on purpose, I guess I've missed something while mergin' the branches.

Let me know if there's something else to update (hopefully not 🤞).

[Adam-it]

LGTM 👍 and works perfectly 👏
I did a couple of small fixups